optionalRequirementOf relationships take precedence over non-optional ones #1252
+39
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://155967920
Summary
Prior to Swift 6.1 (specifically swiftlang/swift#76983), Swift symbol graphs would contain both
requirementOf
andoptionalRequirementOf
relationships for imported optional Objective-C protocol methods. This can confuse Swift-DocC into nondeterministically displaying a "Required" marker for optional requirements based on which relationship it reads last. This PR addresses this nondeterminism by makingoptionalRequirementOf
relationships take precedence overrequirementOf
ones in theSymbolGraphRelationshipsBuilder
.Dependencies
None
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/test
script and it succeeded