SR-11699: Process: Closing standardInput before calling run() aborts with EBADF #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with EBADF - Check the file descriptor passed to _CFPosixSpawnFileActionsAddClose() is valid.
|
@swift-ci test |
|
Aha, when I looked at this earlier when I hit it, I didn’t have quite enough time to ingest what was going on. This makes a lot of sense now that I’ve had time to read it: not checking to see if the FD is already closed before telling the child process to close it (to avoid the child process to have say, write access to the standard input pipe). Thanks for the quick turnaround on this one. |
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
- The fix for SR-11699 also fixes connecting two processes with pipes.
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
|
@swift-ci test and merge |
This was referenced Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is valid.