Skip to content

Fix warnings in the Foundation build #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

pushkarnk
Copy link
Member

Foundation/HTTPCookieStorage.swift:80:29: warning: 'init(contentsOfFile:)' is deprecated
        guard let cookies = NSMutableDictionary(contentsOfFile: cookieFilePath) else { return }

and

Foundation/Data.swift:1593:13: warning: initialization of immutable value 'length' was never used; consider replacing with assignment to '_' or removing it
        let length = count

@alblue
Copy link
Contributor

alblue commented Oct 11, 2017

@swift-ci please test

@pushkarnk
Copy link
Member Author

@swift-ci please test

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

This seems to have unrelated failures in SourceKit:

/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/swift/test/SourceKit/Misc/stats.swift:36:12: error: expected string not found in input
// SEMA_2: 0 {{.*}} source.statistic.num-ast-cache-hits

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

@swift-ci please clean test

1 similar comment
@pushkarnk
Copy link
Member Author

@swift-ci please clean test

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

@swift-ci please smoke test

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

@shahmishal is there an issue with swift-ci not picking up triggers for the Linux platform at the moment?

@shahmishal
Copy link
Member

@swift-ci please smoke test

@shahmishal
Copy link
Member

@swift-ci please test

@shahmishal
Copy link
Member

Foundation repo does not support smoke test trigger, just full test.

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

@shahmishal ah, ok - presumably it doesn't support the clean test either?

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

LGTM

@swift-ci please test and merge

@alblue
Copy link
Contributor

alblue commented Oct 12, 2017

@swift-ci please test and merge

@swift-ci swift-ci merged commit 21fb8e7 into swiftlang:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants