Android: add native support #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
commented
Dec 26, 2019
| case .darwin: return "dylib" | ||
| case .linux: return "so" | ||
| case .linux, .android: return "so" |
There was a problem hiding this comment.
I didn't know you could do this in my earlier pull, so modified it now.
finagolfin
commented
Dec 26, 2019
| @@ -62,9 +62,11 @@ public struct DLOpenFlags: RawRepresentable, OptionSet { | |||
| public static let deepBind: DLOpenFlags = DLOpenFlags(rawValue: 0) | |||
| #else | |||
| public static let first: DLOpenFlags = DLOpenFlags(rawValue: 0) | |||
| #if !os(Android) | |||
| public static let deepBind: DLOpenFlags = DLOpenFlags(rawValue: RTLD_DEEPBIND) | |||
finagolfin
commented
Dec 26, 2019
| '-Xlinker', '-rpath', '-Xlinker', '$ORIGIN/../lib/swift/android', | ||
| # SwiftPM will otherwise try to compile against GNU strerror_r on | ||
| # Android and fail. | ||
| '-Xswiftc', '-Xcc', '-Xswiftc', '-U_GNU_SOURCE', |
There was a problem hiding this comment.
|
@swift-ci please test |
benlangmuir
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull, I got this repo built and tested natively on Android in the Termux app. It shows no failures in the tests, even though the test output dumps a bunch of non-XCTest warnings and errors, just like on the linux CI.