[lldb][swift] Reduce scope of a SwiftReflectionContext #9765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
In the changed function, there is a block of debug-only ifdef'ed code that is pretty heavyweight, and it may acquire a few locks along the way. The SwiftReflectionContext itself also has its own lock. This is triggering a deadlock in some ongoing work. Reducing the scope of the reflection context allows the debug code to run without the lock acquired, and has no effect on release builds.
felipepiovezan
force-pushed
the
felipe/reduce_lock_scope
branch
from
988ac01 to
45b8e54
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Dec 19, 2024
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the changed function, there is a block of debug-only ifdef'ed code that is pretty heavyweight, and it may acquire a few locks along the way. The SwiftReflectionContext itself also has its own lock. This is triggering a deadlock in some ongoing work.
Reducing the scope of the reflection context allows the debug code to run without the lock acquired, and has no effect on release builds.