[lldb] Mark forward C++ interop test XFAIL #9538
Conversation
|
Please test with following pull request: @swift-ci please test |
lldb/test/API/lang/swift/cxx_interop/forward/verbose_trap/TestSwiftForwardInteropVerboseTrap.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
LGTM
C++ imported source locations artifical, some of that code is user written, some is not (coming from frameworks, STL). Moreover, some users might prefer to stop in the C++ code and some users might prefer to stop in Swift code.
In my opinion we shouldn't stop inside STL frames (regardless of whether they're Swift/C++/Swift-C++ interop), since that's what we do with regular libc++ too. Whether to do it by marking those frames artificial, I'm not 100% sure (e.g., that's not what we do for libc++). But I agree that we should have ways to let users step into/stop in the C++ interop glue if they want to.
After Swift PR llvm#77323, we import C++ source locations for imported code. This improves some diagnostics but also breaks some of the heuristics LLDB have to select the right frame on traps. This PR marks the test XFAIL until we figure out a better heuristic to stop at the right frame. This is not a trivial question as we cannot just mark all C++ imported source locations artifical, some of that code is user written, some is not (coming from frameworks, STL). Moreover, some users might prefer to stop in the C++ code and some users might prefer to stop in Swift code.
Xazax-hun
force-pushed
the
mark-lldb-test-xfail
branch
from
6e153ae to
1c0bdf9
Compare
|
Please test with following pull request: @swift-ci please test |
After Swift PR 77323, we import C++ source locations for imported code. This improves some diagnostics but also breaks some of the heuristics LLDB have to select the right frame on traps. This PR marks the test XFAIL until we figure out a better heuristic to stop at the right frame. This is not a trivial question as we cannot just mark all C++ imported source locations artifical, some of that code is user written, some is not (coming from frameworks, STL). Moreover, some users might prefer to stop in the C++ code and some users might prefer to stop in Swift code.