Cherry-picks slide fix #9524
Merged
Cherry-picks slide fix #9524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slide calculation was incorrectly negating an unsigned integer and passing it to a call to SaturatingAdd. The section load address should always be larger than the section file address, so change the underflow check to a comparison instead. (cherry picked from commit 61f28df)
(cherry picked from commit f30387f)
|
@swift-ci test |
kastiglione
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two commits that are missing on stable/20240723, which fix TestSwiftFoundationTypeNotification.py and TestSwiftFoundationTypeNotification.py.