Skip to content

[RuntimeDyld][Windows] Allocate space for dllimport things. #9084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

al45tair
Copy link

@al45tair al45tair commented Aug 9, 2024

We weren't taking account of the space we require in the stubs for things that are dllimported, and as a result we could hit the assertion failure for running out of stub space. Fix that.

rdar://133473673

al45tair and others added 2 commits August 9, 2024 17:47
We weren't taking account of the space we require in the stubs for
things that are `dllimport`ed, and as a result we could hit the
assertion failure for running out of stub space.  Fix that.

rdar://133473673
No need for `TargetName` to exist separately, really.

Co-authored-by: Saleem Abdulrasool <[email protected]>
@al45tair al45tair requested review from compnerd and lhames August 9, 2024 16:49
@al45tair
Copy link
Author

al45tair commented Aug 9, 2024

This is a cherry pick of #9071.

Copy link

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compnerd beat me to it, but LGTM! :)

@al45tair al45tair merged commit adf6422 into swiftlang:stable/20240723 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants