Skip to content

[RuntimeDyld][Windows] Allocate space for dllimport things. #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

al45tair
Copy link

@al45tair al45tair commented Aug 9, 2024

We weren't taking account of the space we require in the stubs for things that are dllimported, and as a result we could hit the assertion failure for running out of stub space. Fix that.

rdar://133473673

We weren't taking account of the space we require in the stubs for
things that are `dllimport`ed, and as a result we could hit the
assertion failure for running out of stub space.  Fix that.

rdar://133473673
@al45tair al45tair requested review from compnerd and lhames August 9, 2024 08:41
@al45tair
Copy link
Author

al45tair commented Aug 9, 2024

This is a cherry pick of #9071 (which I'll be trying to land upstream also; not sure whether it's worth landing it in next ahead of that or not, but I thought I'd create a PR for that just in case).

No need for `TargetName` to exist separately, really.

Co-authored-by: Saleem Abdulrasool <[email protected]>
@al45tair al45tair force-pushed the eng/PR-133473673-next branch from 3eb5121 to 67c8a17 Compare August 9, 2024 08:56
@al45tair
Copy link
Author

al45tair commented Aug 9, 2024

This one is apparently not required.

@al45tair al45tair closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant