[rebranch] Push stable/20240408 changes to next
#8819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c07f420)
…namespace (cherry picked from commit 78598ae)
(cherry picked from commit 3ec9866)
`StreamFile.h` moved from `lldb/Core` to `lldb/Host`. Update Swift references. (cherry picked from commit a1f9c2f)
`eManglingSchemeSwift` is not guarded by `LLDB_ENABLE_SWIFT`, so a case was added upstream. Remove the now duplicated case statement. (cherry picked from commit fb74e31)
(cherry picked from commit 1ca2c5f)
(cherry picked from commit 180103f)
(cherry picked from commit 7df11ff)
Seems there's a `SetTriple` on the context itself now. (cherry picked from commit 2c67baf)
LLVM hid GTest from folks that aren't building as part of LLVM, or that aren't installing GTest. While this is the right thing to do and is totally sensible, it doesn't work with Swift, which does neither. Re-expose GTest for now. This should get cleaned up once Swift builds things reasonably. (cherry picked from commit ade5638)
There's no reason to require random access on downstream clients here. (cherry picked from commit 355f86e)
We want this so we can uniquely identify our fully-static Linux target using a triple (since we wish to make decisions about it in the compiler driver that wouldn't be appropriate for an "unknown" triple). rdar://123436421 (cherry picked from commit 18ba856)
``` <unknown>:0: error: calling a private constructor of class 'clang::StmtIterator' swift/llvm-project/clang/include/clang/AST/StmtIterator.h:137:3: note: declared private here StmtIterator(const StmtIteratorBase &RHS) ^ ``` rdar://113514872 (cherry picked from commit f7b421f)
This reverts commit 648ce3d. rdar://113994760 llvm#64826 (cherry picked from commit 1c7f71c)
bnbarham
requested review from
etcwilde,
adrian-prantl,
al45tair,
jroelofs,
egorzhdan and
aschwaighofer
|
@swift-ci please test llvm |
al45tair
approved these changes
May 31, 2024
|
@swift-ci please test llvm |
etcwilde
approved these changes
Jun 4, 2024
|
@aschwaighofer okay with 141bce5? |
|
PR to upstream that change: llvm#94540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push all the current
stable/20240408changes up tonextin preparation for the next branch. This is mostly LLDB, but also takes a few reverts that keep happening onstable.@adrian-prantl @JDevlieghere for the LLDB changes
@etcwilde for re-exposing GTest
@aschwaighofer for the
getLoopPreheaderchange (this should probably be upstreamed)@al45tair for
Swifttriple@egorzhdan for the cxx-interop workaround
@jroelofs for the revert of "Cleanup unwind table emission code a bit."