Invalidate the reflection metadata cache when new symbols are added. #8181
Conversation
|
@swift-ci test |
|
Is this supposed to be only a test? |
Reflection context maintains several caches for TypeInfos and TypeRefs that also include types it got from LLDBTypeInforProvider, which reads types from DWARF. If new DWARF is available we need to invalidate these caches. rdar://122432501
adrian-prantl
force-pushed
the
122432501
branch
from
39e2f19 to
da3753f
Compare
Fixed! |
|
@swift-ci test |
There was a problem hiding this comment.
I think this is a good change and worth merging as is. There is one downside with the current implementation though, as types that were cached and not affected by the new symbols will be recomputed and leak memory.
I wonder if it's worth preemptively finding a solution for that problem, or if extra symbols being loaded is not common enough to be concerned with at this point.
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Show resolved
Hide resolved
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
That's right. The memory will be freed only at the end of the process, as it's owned by SwiftLanguageRuntime. |
Reflection context maintains several caches for TypeInfos and TypeRefs that also include types it got from LLDBTypeInforProvider, which reads types from DWARF. If new DWARF is available we need to invalidate these caches.
rdar://122432501