Revert "[ASTImporter] Fields are imported first and reordered for correct layout" #7921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect layout" This reverts commit e953669. Prior to this patch, the re-ordering only applied to `RecordDecl`. This patch changed the decls we were iterating from `RecordDecl` to `DeclContext`, which meant we were now also doing this re-ordering for members of `ObjCInterfaceDecl`s. This caused crashes when debugging Objective-C applications with LLDB. Revert for now until we find a way to support `ObjCInterfaceDecl`s properly. rdar://119343184 rdar://119636274 rdar://119832131
|
@swift-ci test |
JDevlieghere
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e953669.
Prior to this patch, the import re-ordering only applied to
RecordDecl. This patch changed thedecls()we were iterating over from aRecordDeclto those of theDeclContext, which meant we were now also doing this re-ordering for members ofObjCInterfaceDecls. This caused crashes when debugging Objective-C applications with LLDB.For Objective-C interfaces this re-ordering doesn't actually make sense because those don't have function bodies, so there's no risk of importing a method body that references a yet-to-be-imported ivar, which is what D154764 attempted to fix.
Revert for now until we find a way to support
ObjCInterfaceDecls properly.rdar://119343184
rdar://119636274
rdar://119832131