[cherry-pick][stable/20230725] [lldb][Symbol] Make sure we decrement PC before checking location list #7862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
approved these changes
Dec 8, 2023
|
@swift-ci test |
llvm#74772) (cherry picked from commit 58bdef2)
…d platforms (llvm#74818) The `expect_expr` check was introduced in llvm#74772. It is failing on Linux and Windows, so skip this test to unblock the bots (cherry picked from commit 11a7e57)
Michael137
force-pushed
the
bugfix/lldb-loclist-cpp-member-to-20230725
branch
from
9a03fdf to
4a827a0
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci please test platform Windows |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stopping in optimized code, we can end up with the return address being the next instruction in a different block. If we are dealing with location lists, we want to decrement the PC value so it's within the calling block range that we're checking against the loclists.
This was addressed in https://reviews.llvm.org/D124597 (
6e56c4961a106b8fde69ffcf9f803fe0890722fa), by introducing aGetFrameCodeAddressForSymbolication. This fixedframe variable, butexprcalls intoVariable::LocationIsValidForFrame, where this new API wasn't used yet.So in the associated test-case, running
frame var thisworks, butexpr thisdoesn't. Withdwim-printthis makes the situation more surprising for the user becausep this,v thisandv *thiswork, butp *thisdoesn't because it falls back ontoexpr(due to the dereference).This patch makes sure we lookup loclists using the correct PC by using this new
GetFrameCodeAddressForSymbolicationAPI.