[lldb/formatter] Add Swift.UnsafeRawBufferPointer data formatter

[medismailben]

This patch adds support for Swift's UnsafeRawBufferPointer and
UnsafeMutableRawBufferPointer data formatting.

This commit also introduces a new SwiftUnsafeType factory to adapt and
use both Unsafe{,Raw}BufferPointer with the pre-existing data formatter.

rdar://63946760

Signed-off-by: Med Ismail Bennani [email protected]

[medismailben]

@swift-ci test

[medismailben]

@swift-ci test Linux Platform

[jimingham]

This looks pretty good. The synthetic provider is leaking its SwiftUnsafeBufferPointer object, and I think you can isolate the choice to make the raw vrs. not raw difference. Once you've made the right object only call base class methods so you should always handle the base class and let a factory make the right one for you.

[medismailben]

Thanks for the feedbacks @jimingham ! Indeed the factory approach would be a good way to manage both types. I'll wait to see if @dcci and @fredriss could think of other improvements I could make then update the PR.

[hixio-mh]

Merge pull requested

[medismailben]

I updated the patch addressing @jimingham comments:

• Added a SwiftUnsafeType factory for UnsafeBufferPointer and UnsafeRawBufferPointer
• Used std::unique_ptr instead of a raw pointer.
• Added the test Jim requested.

[medismailben]

@swift-ci test

[jimingham]

That looks better to me.

You have to handle the case where the valobj is a typedef to UnsafeBufferPointer or UnsafeRawBufferPointer. Just strip off typedef's before looking for the "Raw" in the typename.

You might also want to think a bit about "if this were to fail in the field, where would I wish I had put in logging to help me figure out what went wrong" and if there are any obvious places add some "formatter" channel logging

[dcci]

A round of comments.

[medismailben]

@swift-ci test

[jimingham]

A few nits and one annoyance w.r.t. typedef's.

[medismailben]

Addressed final round of comments:

• Handled typedef chaining and added test for it
• Fixed typos.
• Added logging.

[medismailben]

@swift-ci test