[lldb] Make sure to eliminate ownership after the diagnostic passes, … #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but before IRGen. Before I flip the switch, this will be a no-op. It is needed though after I flip the switch since IRgen is not meant to see ownership SIL.
|
This will be a no-op before I flip the switch for moving ownership lowering after diagnostics. After I flip the switch, it will be necessary since IRGen is not setup to see ownership SIL. |
|
@swift-ci test |
dcci
reviewed
Nov 4, 2019
swift-ci
pushed a commit
that referenced
this pull request
May 7, 2023
…ions MSVC makes these string literals [1][2]. [1] https://godbolt.org/z/6vnTzbExx [2] https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Fixes #114 Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D146764
swift-ci
pushed a commit
that referenced
this pull request
May 10, 2023
…-extensions MSVC makes these string literals [1][2]. [1] https://godbolt.org/z/6vnTzbExx [2] https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Fixes #114 Initial commit didn't check if there was a function name when stepping through expressions ignoring parens. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D146764
swift-ci
pushed a commit
that referenced
this pull request
Nov 8, 2024
llvm#115539) …293)" This reverts commit da9499e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…but before IRGen.
Before I flip the switch, this will be a no-op. It is needed though after I flip
the switch since IRgen is not meant to see ownership SIL.