Skip to content

[lldb] add syntax highlighting infrastructure to Swift plugin #10852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: swift/release/6.2
Choose a base branch
from

Conversation

charles-zablit
Copy link

This PR adds the infrastructure needed to implement function name syntax highlighting in LLDB Swift backtraces.

Motivation

In this patch, @Michael137 implemented name highlighting for methods in the C++ plugin of LLDB. This results in better readability when reading backtraces of functions with long scopes.

Implementation details

This patch only adds the infrastructure/boilerplate needed to implement the feature. The rest of the modifications will be added in #10710.

@charles-zablit charles-zablit requested a review from a team as a code owner June 17, 2025 12:01
Copy link

@Michael137 Michael137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/add-formatting-swift-plugin branch from 0ac3111 to 6909a5f Compare June 17, 2025 15:47
@charles-zablit
Copy link
Author

@swift-ci please test

@@ -0,0 +1,8 @@
include "../../../../include/lldb/Core/PropertiesBase.td"

let Definition = "language_swift" in {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think keeping it consistent with all the other plugin setting names seems like the right thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants