Merge pull request #20 from dcci/itsallmyfault

JDevlieghere · web-flow · commit dc55182b6310 · 2019-10-25T13:56:03.000-07:00
Reintroduce some seemingly unused code. A test fails.
diff --git a/lldb/source/Target/SwiftLanguageRuntime.cpp b/lldb/source/Target/SwiftLanguageRuntime.cpp
@@ -1983,6 +1983,13 @@ Value::ValueType SwiftLanguageRuntime::GetValueType(
                                       eTypeInstanceIsPointer))
         return Value::eValueTypeLoadAddress;
     }
+
+    if (static_type_flags.AllSet(eTypeIsSwift | eTypeIsPointer) &&
+        static_type_flags.AllClear(eTypeIsGenericTypeParam)) {
+      // FIXME: This branch is not covered by any testcases in the test suite.
+      if (is_indirect_enum_case || static_type_flags.AllClear(eTypeIsBuiltIn))
+        return Value::eValueTypeLoadAddress;
+    }
   }
 
   // Enabling this makes the inout_variables test hang.

Original file line number	Diff line number	Diff line change
`@@ -1983,6 +1983,13 @@ Value::ValueType SwiftLanguageRuntime::GetValueType(`
`1983`	`1983`	`eTypeInstanceIsPointer))`
`1984`	`1984`	`return Value::eValueTypeLoadAddress;`
`1985`	`1985`	`}`
	`1986`	`+`
	`1987`	`+ if (static_type_flags.AllSet(eTypeIsSwift \| eTypeIsPointer) &&`
	`1988`	`+ static_type_flags.AllClear(eTypeIsGenericTypeParam)) {`
	`1989`	`+ // FIXME: This branch is not covered by any testcases in the test suite.`
	`1990`	`+ if (is_indirect_enum_case \|\| static_type_flags.AllClear(eTypeIsBuiltIn))`
	`1991`	`+ return Value::eValueTypeLoadAddress;`
	`1992`	`+ }`
`1986`	`1993`	`}`
`1987`	`1994`
`1988`	`1995`	`// Enabling this makes the inout_variables test hang.`