Merge pull request #48 from JDevlieghere/revert-valueobject

Revert "ValueObject: Fix a crash related to children address type com…

Author: shahmishal

lldb/include/lldb/Core/ValueObject.h

@@ -990,7 +990,6 @@ class ValueObject : public UserID {
 
 private:
   virtual CompilerType MaybeCalculateCompleteType();
-  void UpdateChildrenAddressType();
 
   lldb::ValueObjectSP GetValueForExpressionPath_Impl(
       llvm::StringRef expression_cstr,

lldb/lit/SymbolFile/DWARF/DW_OP_piece-struct.s

@@ -152,58 +152,6 @@ ValueObject::ValueObject(ExecutionContextScope *exe_scope,
 // Destructor
 ValueObject::~ValueObject() {}
 
-void ValueObject::UpdateChildrenAddressType() {
-  Value::ValueType value_type = m_value.GetValueType();
-  ExecutionContext exe_ctx(GetExecutionContextRef());
-  Process *process = exe_ctx.GetProcessPtr();
-  const bool process_is_alive = process && process->IsAlive();
-  const uint32_t type_info = GetCompilerType().GetTypeInfo();
-  const bool is_pointer_or_ref =
-      (type_info & (lldb::eTypeIsPointer | lldb::eTypeIsReference)) != 0;
-
-  switch (value_type) {
-  case Value::eValueTypeFileAddress:
-    // If this type is a pointer, then its children will be considered load
-    // addresses if the pointer or reference is dereferenced, but only if
-    // the process is alive.
-    //
-    // There could be global variables like in the following code:
-    // struct LinkedListNode { Foo* foo; LinkedListNode* next; };
-    // Foo g_foo1;
-    // Foo g_foo2;
-    // LinkedListNode g_second_node = { &g_foo2, NULL };
-    // LinkedListNode g_first_node = { &g_foo1, &g_second_node };
-    //
-    // When we aren't running, we should be able to look at these variables
-    // using the "target variable" command. Children of the "g_first_node"
-    // always will be of the same address type as the parent. But children
-    // of the "next" member of LinkedListNode will become load addresses if
-    // we have a live process, or remain a file address if it was a file
-    // address.
-    if (process_is_alive && is_pointer_or_ref)
-      SetAddressTypeOfChildren(eAddressTypeLoad);
-    else
-      SetAddressTypeOfChildren(eAddressTypeFile);
-    break;
-  case Value::eValueTypeHostAddress:
-    // Same as above for load addresses, except children of pointer or refs
-    // are always load addresses. Host addresses are used to store freeze
-    // dried variables. If this type is a struct, the entire struct
-    // contents will be copied into the heap of the
-    // LLDB process, but we do not currently follow any pointers.
-    if (is_pointer_or_ref)
-      SetAddressTypeOfChildren(eAddressTypeLoad);
-    else
-      SetAddressTypeOfChildren(eAddressTypeHost);
-    break;
-  case Value::eValueTypeLoadAddress:
-  case Value::eValueTypeScalar:
-  case Value::eValueTypeVector:
-    SetAddressTypeOfChildren(eAddressTypeLoad);
-    break;
-  }
-}
-
 bool ValueObject::UpdateValueIfNeeded(bool update_format) {
 
   bool did_change_formats = false;
@@ -275,7 +223,6 @@ bool ValueObject::UpdateValueIfNeeded(bool update_format) {
       SetValueIsValid(success);
 
       if (success) {
-        UpdateChildrenAddressType();
         const uint64_t max_checksum_size = 128;
         m_data.Checksum(m_value_checksum, max_checksum_size);
       } else {

lldb/source/Core/ValueObject.cpp

@@ -190,6 +190,51 @@ bool ValueObjectVariable::UpdateValue() {
 
       Process *process = exe_ctx.GetProcessPtr();
       const bool process_is_alive = process && process->IsAlive();
+      const uint32_t type_info = compiler_type.GetTypeInfo();
+      const bool is_pointer_or_ref =
+          (type_info & (lldb::eTypeIsPointer | lldb::eTypeIsReference)) != 0;
+
+      switch (value_type) {
+      case Value::eValueTypeFileAddress:
+        // If this type is a pointer, then its children will be considered load
+        // addresses if the pointer or reference is dereferenced, but only if
+        // the process is alive.
+        //
+        // There could be global variables like in the following code:
+        // struct LinkedListNode { Foo* foo; LinkedListNode* next; };
+        // Foo g_foo1;
+        // Foo g_foo2;
+        // LinkedListNode g_second_node = { &g_foo2, NULL };
+        // LinkedListNode g_first_node = { &g_foo1, &g_second_node };
+        //
+        // When we aren't running, we should be able to look at these variables
+        // using the "target variable" command. Children of the "g_first_node"
+        // always will be of the same address type as the parent. But children
+        // of the "next" member of LinkedListNode will become load addresses if
+        // we have a live process, or remain what a file address if it what a
+        // file address.
+        if (process_is_alive && is_pointer_or_ref)
+          SetAddressTypeOfChildren(eAddressTypeLoad);
+        else
+          SetAddressTypeOfChildren(eAddressTypeFile);
+        break;
+      case Value::eValueTypeHostAddress:
+        // Same as above for load addresses, except children of pointer or refs
+        // are always load addresses. Host addresses are used to store freeze
+        // dried variables. If this type is a struct, the entire struct
+        // contents will be copied into the heap of the
+        // LLDB process, but we do not currently follow any pointers.
+        if (is_pointer_or_ref)
+          SetAddressTypeOfChildren(eAddressTypeLoad);
+        else
+          SetAddressTypeOfChildren(eAddressTypeHost);
+        break;
+      case Value::eValueTypeLoadAddress:
+      case Value::eValueTypeScalar:
+      case Value::eValueTypeVector:
+        SetAddressTypeOfChildren(eAddressTypeLoad);
+        break;
+      }
 
       // BEGIN Swift
       if (variable->GetType() && variable->GetType()->IsSwiftFixedValueBuffer())