Add support for Musl. #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Jan 17, 2024
|
@swift-server-bot test this please |
dnadoba
approved these changes
Jan 17, 2024
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
Motivation: We would like to make this work for Musl so that we can build fully statically linked binaries that use AsyncHTTPClient. Modifications: Define `_GNU_SOURCE` as a compiler argument; doing it in a source file doesn't work properly with modular headers. Add imports of `Musl` in appropriate places. `Musl` doesn't have `strptime_l`, so avoid using that. Result: async-http-client will build for Musl.
auto-merge was automatically disabled
January 18, 2024 15:17
Head branch was pushed to by a user without write access
al45tair
force-pushed
the
musl-support
branch
from
5b00a9b to
4c53cbe
Compare
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
@swift-server-bot add to allow list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to make this work for Musl so that we can build fully statically linked binaries that use AsyncHTTPClient.
Modifications
Define
_GNU_SOURCEas a compiler argument; doing it in a source file doesn't work properly with modular headers.Add imports of
Muslin appropriate places.Musldoesn't havestrptime_l, so avoid using that.Result
async-http-client will build for Musl.