Skip to content

Replace os() with canImport(Darwin) #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Replace os() with canImport(Darwin) #693

merged 2 commits into from
Jun 26, 2023

Conversation

o-nnerb
Copy link
Contributor

@o-nnerb o-nnerb commented Jun 22, 2023

This increase the code verification with the right statement including all platforms that use Darwin.

@FranzBusch
Copy link
Collaborator

@swift-server-bot add to allowlist

@o-nnerb
Copy link
Contributor Author

o-nnerb commented Jun 23, 2023

@FranzBusch I've updated this branch but now the scope of this PR has change. Do I need to update the title? I think it'll be more clear for those who pass by.

@o-nnerb o-nnerb requested a review from FranzBusch June 23, 2023 09:48
@FranzBusch
Copy link
Collaborator

@swift-server-bot test this please

@o-nnerb
Copy link
Contributor Author

o-nnerb commented Jun 24, 2023

@FranzBusch I think you need to approve this PR again. I made some changes yesterday, before your comment, and request a new review 😅

@Lukasa
Copy link
Collaborator

Lukasa commented Jun 26, 2023

@swift-server-bot add to allowlist

@Lukasa Lukasa enabled auto-merge (squash) June 26, 2023 07:17
@Lukasa Lukasa merged commit c7fb775 into swift-server:main Jun 26, 2023
@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants