Skip to content

Fix building transaction extension for Apple Platforms #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 14, 2023

The project currently won't build for other OS's because the extension doesn't match:

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
@usableFromInline final class Transaction: @unchecked Sendable {

@dnadoba
Copy link
Collaborator

dnadoba commented Apr 14, 2023

@swift-server-bot test this please

@dnadoba
Copy link
Collaborator

dnadoba commented Apr 14, 2023

Good catch and thanks a lot for opening a PR to fix it!
resolves #684

@dnadoba dnadoba enabled auto-merge (squash) April 14, 2023 13:00
@dnadoba dnadoba merged commit 333e60c into swift-server:main Apr 14, 2023
@cbaker6 cbaker6 deleted the patch-1 branch April 14, 2023 13:10
@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants