Handle ResponseAccumulator not being able to buffer large response in memory #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… memory Check content length header for early exit
dnadoba
force-pushed
the
dn-max-buffer-size
branch
from
e675f60 to
a9122e8
Compare
gjcairo
reviewed
Oct 8, 2022
| public var maxBodySize: Int = maxByteBufferSize { | ||
| didSet { | ||
| precondition( | ||
| self.maxBodySize <= Self.maxByteBufferSize, |
There was a problem hiding this comment.
Relatively minor, but wouldn't it also make sense to verify that the new value isn't negative?
Lukasa
requested changes
Oct 8, 2022
| public init(request: HTTPClient.Request) { | ||
| self.request = request | ||
| } | ||
|
|
||
| public func didReceiveHead(task: HTTPClient.Task<Response>, _ head: HTTPResponseHead) -> EventLoopFuture<Void> { | ||
| switch self.state { | ||
| case .idle: | ||
| if let contentLength = head.headers.first(name: "Content-Length"), | ||
| let announcedBodySize = Int(contentLength), |
There was a problem hiding this comment.
Should we be tolerating the possibility of a non-integer Content-Length field here?
There was a problem hiding this comment.
That's at least what we do in swift-nio so far:
https://github.com/apple/swift-nio/blob/41f0b2d3983038ae68bbb902ea43e123a5466494/Sources/NIOHTTP1/HTTPTypes.swift#L1508
dnadoba
force-pushed
the
dn-max-buffer-size
branch
from
075241b to
986bb05
Compare
Lukasa
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the response being buffered by the
ResponseAccumulatoris too large (larger thanUInt32.max), a crash will occur.Modifications
public var maxBodySize: IntonResponseAccumulatorResponseTooBigErrorif the response bodies size is larger thanmaxBodySizeResult
Will now fail graciously if too big a response is buffered in memory via the
ResponseAccumulator.In addition, a user can configure the max size themself.