Skip to content

NIOFoundationCompat does not appear to be used #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2022
Merged

NIOFoundationCompat does not appear to be used #619

merged 2 commits into from
Aug 20, 2022

Conversation

karwa
Copy link
Contributor

@karwa karwa commented Aug 20, 2022

No description provided.

Lukasa
Lukasa approved these changes Aug 20, 2022
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is vestigial from a time when we used URL or Data.

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Aug 20, 2022
@Lukasa Lukasa enabled auto-merge (squash) August 20, 2022 11:23
@Lukasa Lukasa merged commit d764c1a into swift-server:main Aug 20, 2022
@karwa karwa deleted the unused-compat branch August 20, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karwa @Lukasa