Fix flaky HTTPClientTests.testResponseDelayGet() test
#584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that we need a code format run |
Lukasa
approved these changes
Apr 21, 2022
if `numberFormatting` is disable, it will allows us to add `_` in number literals when appropriate
|
5.7 & nightly fail because of sendable related errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We observed a test failure on our CI:
Modification
I could not reproduce the failure myself but giving this a bit more leeway does not hurt. To measure the time difference, we now use
NIODeadlinewhich internally uses nanoseconds since boot to measure the time instead ofDate.Dateuses the system time which may change during execution due to time sync with a time server and is therefore not best suited to measure elapsed time.Result
Immune to system time sync and slightly higher tolerance agains inaccurate timer implementations.