Add a RequestQueue #412
Add a RequestQueue #412
Conversation
fabianfett
added
🔨 semver/patch
fabianfett
force-pushed
the
ff-pool-state-queue
branch
from
ddc0233 to
77809cc
Compare
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
I think the queue has some surprising behaviour that should be changed or at least made much clearer.
| self.generalPurposeQueue.isEmpty | ||
| } | ||
|
|
||
| mutating func count(for eventLoop: EventLoop?) -> Int { |
There was a problem hiding this comment.
I think as a user I'd be very surprised that getting the count is mutating and potentially allocates!
Perhaps there should be a non-mutating version of withEventLoopQueue, something like:
func withEventLoopQueueIfAvailable<Result>(
for eventLoopID: EventLoopID,
_ closure: (CircularBuffer<Request>) -> Result
) -> Result?| return self.generalPurposeQueue.count | ||
| } | ||
|
|
||
| mutating func isEmpty(for eventLoop: EventLoop?) -> Bool { |
|
|
||
| mutating func removeAll() -> [Request] { | ||
| var result = [Request]() | ||
| result = self.eventLoopQueues.reduce(into: result) { partialResult, element in |
There was a problem hiding this comment.
Isn't this just eventLoopQueues.flatMap { $1 }?
| self.generalPurposeQueue.forEach { request in | ||
| result.append(request) | ||
| } |
There was a problem hiding this comment.
Use result.append(contentsOf: self.generalPurposeQueue) to avoid intermediate reallocs of result
Sources/AsyncHTTPClient/ConnectionPool/State Machine/HTTPConnectionPool+RequestQueue.swift
Show resolved
Hide resolved
| import NIOEmbedded | ||
|
|
||
| /// An `EventLoopGroup` of `EmbeddedEventLoop`s. | ||
| final class EmbeddedEventLoopGroup: EventLoopGroup { |
| var count: Int { | ||
| self.generalPurposeQueue.count | ||
| } | ||
|
|
||
| var isEmpty: Bool { | ||
| self.generalPurposeQueue.isEmpty | ||
| } |
There was a problem hiding this comment.
This is surprising behaviour I think -- I would expect the count to return the total count and isEmpty to only return true if both queues are empty.
| } | ||
| } | ||
|
|
||
| func __testOnly_internal_value() -> HTTPSchedulableRequest { |
There was a problem hiding this comment.
nit: "wrapped request" or similar would be clearer than internal_value
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks good modulo a couple of nits
| self.count = 0 | ||
| } | ||
|
|
||
| private(set) var count: Int |
There was a problem hiding this comment.
How often is this used externally? If it's not used frequently then dynamically computing this would be better I think...
| if self.eventLoopQueues[eventLoopID] != nil { | ||
| return closure(self.eventLoopQueues[eventLoopID]!) |
There was a problem hiding this comment.
nit: avoid hashing twice here (also we can avoid the bang)
2 participants
Motivation
For our Connection Pool we need to queue requests.
Changes
Waitertype... Not needed anymore.RequestboxRequestQueueResult
Less code in the actual state machine.