Rename package to NIOHTTPClient #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming in different Swift projects should be consistent, in order to achieve this I propose (as recommended by @tomerd) to rename SwiftNIOHTTP to NIOHTTPClient Modifications: Updated naming in Package.swift Renamed directories Sources/SwiftNIOHTTP and Tests/SwiftNIOHTTPTests to Sources/NIOHTTPClient and Tests/NIOHTTPClientTests Updated imports in tests Result: Package is now called NIOHTTPClient
tomerd
reviewed
Apr 10, 2019
Package.swift
Outdated
| @@ -16,20 +16,20 @@ | |||
| import PackageDescription | |||
|
|
|||
| let package = Package( | |||
| name: "SwiftNIOHTTP", | |||
| name: "NIOHTTPClient", | |||
There was a problem hiding this comment.
here we should use swift-nio-http-client
see the example set in swift-nio, swift-log, etc
|
looks good, only one comment, lets get #2 first tho |
tomerd
approved these changes
Apr 10, 2019
weissi
pushed a commit
to weissi/async-http-client
that referenced
this pull request
Mar 3, 2020
test delayed close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Naming in different Swift projects should be consistent, in order to
achieve this I propose (as recommended by @tomerd) to rename
SwiftNIOHTTP to NIOHTTPClient
Modifications:
Updated naming in Package.swift
Renamed directories Sources/SwiftNIOHTTP and Tests/SwiftNIOHTTPTests to
Sources/NIOHTTPClient and Tests/NIOHTTPClientTests
Updated imports in tests
Result:
Package is now called NIOHTTPClient