Add HTTP1ConnectionStateMachine #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-http1-connection-state-machine
branch
from
bb2cc34 to
d1a5e4c
Compare
Lukasa
reviewed
Jul 7, 2021
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This generally seems reasonable to me.
fabianfett
force-pushed
the
ff-http1-connection-state-machine
branch
from
d1a5e4c to
dd3cd57
Compare
Lukasa
approved these changes
Jul 8, 2021
fabianfett
force-pushed
the
ff-http1-connection-state-machine
branch
3 times, most recently
from
5e2e805 to
de48e1d
Compare
fabianfett
force-pushed
the
ff-http1-connection-state-machine
branch
from
de48e1d to
0805daa
Compare
fabianfett
added
🔨 semver/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
HTTP1ConnectionStateMachinethat shall be used in an upcomingHTTP1ChannelHandler.This PR doesn't have any tests yet. I would like to get some early feedback on the general form and will then add tests.