Revisit settings/configuration Timeout type naming

[ktoso]

Hi there, was skimming the APIs a little bit and found the configuration type names a bit weird.

Specifically, the fields of Configuration using short names looks fun, but is also quite confusing imho, e.g. Timeout:

        var config = HTTPClient.Configuration()
        config.timeout = HTTPClient.Timeout() // this is not "a" Timeout, but configuration

        // a) rename? TimeoutConfiguration
        let t = HTTPClient.TimeoutConfiguration()
        // b) move? 
        let t = HTTPClient.Configuration.Timeout()

The types are nested in HTTPClient which makes it read like "this is the http client timeout", which it is not, it is just the settings what time timeouts shall be.

Looking at types:

public struct Configuration {
    public var tlsConfiguration: TLSConfiguration?
    public var followRedirects: Bool
    public var timeout: Timeout
    public var proxy: Proxy?
}

Timeout should likely be called TimeoutConfiguration; WDYT?

Proxy is likely fine, since that indeed is the value of the proxy to be used... though tbh future proof would be to make it a Configuration as well IMHO (in case it'd get per destination proxying or not etc)

[tomerd]

my vote would be HTTPClient.Configuration.Timeout, which is what we did for Proxy in #90. if we choose different approach lets change both to be the same way. happy to do the PR, lets just see what folks prefer

[tomerd]

@artemredkin @ianpartridge @tanner0101

[ianpartridge]

HTTPClient.Configuration.Timeout is fine by me.