-
Notifications
You must be signed in to change notification settings - Fork 125
flaky test: testRaceNewRequestsVsShutdown: Attempting to use HTTP1ConnectionProvider with unexpected state: closing (expected: [opened]) #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
actually, with this diff applied, it's a 100% repro for me:
|
Thank you! |
hit again in CI (5.0)
|
Yeah, I'm working on it, hopefully will have something by the end of the week |
@artemredkin oh sorry, I just realise the failure I just pasted is different to the what the ticket itself is about. Are you chatting to @adtrevor too? He's working on a patch for the '-1 leased connections' I think? |
Not sure about Trevor, I've been trying to re-factor connection release a bit myself, it should address both issues |
@artemredkin It's great if you have a code re-factor because IMO it's really hard right now to reason about the client state as a whole. I do have a start for a fix: https://github.com/adtrevor/async-http-client/tree/final-state-fix (already merged the async shutdown commit into this) I don't know how these changes overlap with yours, if it overlaps too much I guess the best thing to do will probably be to pick one (probably yours since the refactor must simplify the code) and just check it does address every single the other commit fixed. WDYT? |
bt:
p self:
po self:
The text was updated successfully, but these errors were encountered: