Soundness

Author: dnadoba

Sources/AsyncHTTPClient/ConnectionPool/HTTP2/HTTP2Connection.swift

@@ -278,11 +278,11 @@ final class HTTP2Connection {
             // inform the idle connection handler, that connection should be closed, once all streams
             // are closed.
             self.channel.triggerUserOutboundEvent(HTTPConnectionEvent.shutdownRequested, promise: nil)
-            
+
         case .closed, .closing:
             // we are already closing/closed and we need to tolerate this
             break
-            
+
         case .initialized, .starting:
             preconditionFailure("invalid state \(self.state)")
         }

Tests/AsyncHTTPClientTests/HTTP2ConnectionTests+XCTest.swift

@@ -26,6 +26,7 @@ extension HTTP2ConnectionTests {
     static var allTests: [(String, (HTTP2ConnectionTests) -> () throws -> Void)] {
         return [
             ("testCreateNewConnectionFailureClosedIO", testCreateNewConnectionFailureClosedIO),
+            ("testConnectionToleratesShutdownEventsAfterAlreadyClosed", testConnectionToleratesShutdownEventsAfterAlreadyClosed),
             ("testSimpleGetRequest", testSimpleGetRequest),
             ("testEveryDoneRequestLeadsToAStreamAvailableCall", testEveryDoneRequestLeadsToAStreamAvailableCall),
             ("testCancelAllRunningRequests", testCancelAllRunningRequests),

Tests/AsyncHTTPClientTests/HTTP2ConnectionTests.swift

@@ -41,11 +41,11 @@ class HTTP2ConnectionTests: XCTestCase {
             logger: logger
         ).wait())
     }
-    
+
     func testConnectionToleratesShutdownEventsAfterAlreadyClosed() {
         let embedded = EmbeddedChannel()
         XCTAssertNoThrow(try embedded.connect(to: SocketAddress(ipAddress: "127.0.0.1", port: 3000)).wait())
-        
+
         let logger = Logger(label: "test.http2.connection")
         let connection = HTTP2Connection(
             channel: embedded,
@@ -55,11 +55,11 @@ class HTTP2ConnectionTests: XCTestCase {
             logger: logger
         )
         _ = connection.start()
-        
+
         XCTAssertNoThrow(try embedded.close().wait())
         // to really destroy the channel we need to tick once
         embedded.embeddedEventLoop.run()
-        
+
         // should not crash
         connection.shutdown()
     }