fixup! ci: Run static code analysis

Author: ltoenning

.github/workflows/build.yml

@@ -33,7 +33,6 @@ jobs:
     if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository }}
     outputs:
       version: ${{ steps.version.outputs.value }}
-      should_run: ${{ steps.check_static_analysis.outputs.should_run }}
 
     steps:
       - name: Checkout repository
@@ -44,14 +43,6 @@ jobs:
         id: version
         run: |
           echo "value=$(python3 -u scripts/utils.py --version)" >>$GITHUB_OUTPUT
-      - name: Check if static analysis is required
-        id: check_static_analysis
-        run: |
-          if python3 -u scripts/run_static_analysis.py --check-changed-files; then
-            echo "should_run=false" >> $GITHUB_OUTPUT
-          else
-            echo "should_run=true" >> $GITHUB_OUTPUT
-          fi
       - name: Remove artifacts
         uses: swift-project/delete-artifact@swift
         with:
@@ -72,6 +63,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: '0'
+          submodules: 'true'
       - name: Install gitlint
         run: |
           pip install gitlint==0.19.1
@@ -114,29 +106,28 @@ jobs:
         uses: actions/upload-pages-artifact@v3
         with:
           path: docs/html/
-
-  staticAnalysis:
-    runs-on: ubuntu-22.04
-    needs: [ preBuild, checks ]
-    if: ${{ needs.preBuild.outputs.should_run == 'true' }}
-    steps:
+      - name: Check if clang-tidy analysis is required
+        id: check_need_clang_tidy
+        run: |
+          if python3 -u scripts/run_static_analysis.py --check-changed-files; then
+            echo "should_run_clang_tidy=false" >> $GITHUB_OUTPUT
+          else
+            echo "should_run_clang_tidy=true" >> $GITHUB_OUTPUT
+          fi
       - name: Install Qt
+        if: ${{ steps.check_need_clang_tidy.outputs.should_run_clang_tidy == 'true' }}
         uses: jurplel/install-qt-action@v4
         with:
           version: ${{ env.qt_version }}
           modules: 'qtmultimedia'
           cache: true
       - name: Install dependencies
+        if: ${{ steps.check_need_clang_tidy.outputs.should_run_clang_tidy == 'true' }}
         run: |
           sudo apt-get -y install dbus-x11 libglu1-mesa-dev libpulse-dev libdbus-1-dev ninja-build
           pip3 install requests conan
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          submodules: true
-          fetch-depth: 0
       - name: Checkout externals
-        if: ${{ env.use_externals == 'true' }}
+        if: ${{ env.use_externals == 'true' && steps.check_need_clang_tidy.outputs.should_run_clang_tidy == 'true' }}
         uses: actions/checkout@v4
         env:
           EXTERNALS_PAT: ${{ secrets.EXTERNALS_PAT }}
@@ -146,6 +137,7 @@ jobs:
           token: ${{ env.EXTERNALS_PAT }}
           path: 'third_party/externals'
       - name: Install conan dependencies
+        if: ${{ steps.check_need_clang_tidy.outputs.should_run_clang_tidy == 'true' }}
         shell: bash
         env:
           ARTIFACTORY_USER: ${{ secrets.ARTIFACTORY_USER }}
@@ -157,6 +149,7 @@ jobs:
           conan remote login swift "$ARTIFACTORY_USER" --password "$ARTIFACTORY_TOKEN"
           conan install . --output-folder=build_conan --deployer=full_deploy -pr=ci/profile_linux
       - name: Run clang-tidy
+        if: ${{ steps.check_need_clang_tidy.outputs.should_run_clang_tidy == 'true' }}
         shell: bash
         run: |
           mkdir build && pushd build
@@ -166,7 +159,7 @@ jobs:
 
   buildLinux:
     runs-on: ubuntu-22.04
-    needs: [preBuild, checks, staticAnalysis]
+    needs: [preBuild, checks]
     env:
       BACKTRACE_SYMBOL_TOKEN: ${{ secrets.BACKTRACE_SYMBOL_TOKEN }}
       BACKTRACE_MINIDUMP_TOKEN: ${{ secrets.BACKTRACE_MINIDUMP_TOKEN }}
@@ -270,7 +263,7 @@ jobs:
 
   buildWin64:
     runs-on: windows-2022
-    needs: [preBuild, checks, staticAnalysis]
+    needs: [preBuild, checks]
     env:
       BACKTRACE_SYMBOL_TOKEN: ${{ secrets.BACKTRACE_SYMBOL_TOKEN }}
       BACKTRACE_MINIDUMP_TOKEN: ${{ secrets.BACKTRACE_MINIDUMP_TOKEN }}
@@ -381,7 +374,7 @@ jobs:
 
   buildMacOS:
     runs-on: macos-13
-    needs: [preBuild, checks, staticAnalysis]
+    needs: [preBuild, checks]
     env:
       BACKTRACE_SYMBOL_TOKEN: ${{ secrets.BACKTRACE_SYMBOL_TOKEN }}
       BACKTRACE_MINIDUMP_TOKEN: ${{ secrets.BACKTRACE_MINIDUMP_TOKEN }}
@@ -490,7 +483,7 @@ jobs:
 
   postBuild:
     runs-on: ubuntu-22.04
-    needs: [preBuild, checks, staticAnalysis, buildLinux, buildWin64, buildMacOS]
+    needs: [preBuild, checks, buildLinux, buildWin64, buildMacOS]
 
     steps:
       - name: Download xswiftbus-thin