refactor: Fix readability-simplify-boolean-expr

Author: ltoenning

.clang-tidy

@@ -47,6 +47,7 @@ Checks: >
   readability-redundant-member-init,
   cppcoreguidelines-init-variables,
   readability-static-accessed-through-instance,
+  readability-simplify-boolean-expr,
 
 CheckOptions:
   - key: readability-identifier-naming.ClassCase

src/core/application.cpp

@@ -405,9 +405,7 @@ namespace swift::core
         if (CBuildConfig::isLocalDeveloperDebugBuild()) { return true; }
 
         const CDistribution d(this->getOwnDistribution());
-        if (d.isRestricted() && this->isSet(m_cmdDevelopment)) { return true; }
-
-        return false;
+        return d.isRestricted() && this->isSet(m_cmdDevelopment);
     }
 
     CStatusMessage CApplication::initLocalSettings()

src/core/context/contextsimulator.cpp

@@ -53,7 +53,6 @@ namespace swift::core::context
 
     bool IContextSimulator::isSimulatorSimulating() const
     {
-        if (!isSimulatorAvailable() || !getSimulatorStatus().testFlag(ISimulator::Simulating)) { return false; }
-        return true;
+        return isSimulatorAvailable() && getSimulatorStatus().testFlag(ISimulator::Simulating);
     }
 } // namespace swift::core::context

src/core/fsd/servererror.cpp

@@ -26,8 +26,7 @@ namespace swift::core::fsd
             ServerErrorCode::AuthTimeout,
         };
 
-        if (fatalErrors.contains(m_errorNumber)) { return true; }
-        else { return false; }
+        return fatalErrors.contains(m_errorNumber);
     }
 
     QStringList ServerError::toTokens() const

src/gui/components/atcstationcomponent.cpp

@@ -419,8 +419,7 @@ namespace swift::gui::components
 
     bool CAtcStationComponent::canAccessContext() const
     {
-        if (!sGui || sGui->isShuttingDown() || !sGui->getIContextNetwork()) { return false; }
-        return true;
+        return sGui && !sGui->isShuttingDown() && sGui->getIContextNetwork();
     }
 
     void CAtcStationComponent::clearOnlineViews()

src/gui/dockwidgetinfoarea.cpp

@@ -48,11 +48,7 @@ namespace swift::gui
         if (!this->isVisible()) { return false; }
 
         // further checks
-        if (this->isFloating())
-        {
-            if (this->isMinimized()) { return false; }
-            return true;
-        }
+        if (this->isFloating()) { return !this->isMinimized(); }
         else { return isSelectedDockWidget(); }
     }
 

src/gui/infoarea.cpp

@@ -543,7 +543,7 @@ namespace swift::gui
     {
         if (!sGui || sGui->isShuttingDown()) { return; }
         this->setTabPosition(Qt::LeftDockWidgetArea, QTabWidget::East);
-        const bool init = m_tabBar ? false : true;
+        const bool init = m_tabBar == nullptr;
 
         for (int i = 0; i < m_dockWidgetInfoAreas.size(); i++)
         {

src/gui/managedstatusbar.cpp

@@ -40,7 +40,7 @@ namespace swift::gui
     void CManagedStatusBar::initStatusBar(QStatusBar *statusBar)
     {
         if (m_statusBar) { return; }
-        m_ownedStatusBar = statusBar ? false : true;
+        m_ownedStatusBar = statusBar == nullptr;
         m_statusBar = statusBar ? statusBar : new QStatusBar();
         if (m_statusBar->objectName().isEmpty()) { m_statusBar->setObjectName("sb_ManagedStatusBar"); }
 

src/gui/models/airlineicaofilter.cpp

@@ -14,8 +14,8 @@ namespace swift::gui::models
         : m_id(id), m_vDesignator(vDesignator.trimmed().toUpper()), m_name(name.trimmed()),
           m_countryIso(countryIso.trimmed().toUpper()), m_real(isReal), m_va(isVa)
     {
-        this->m_valid = !(m_id < 0 && this->m_countryIso.isEmpty() && this->m_vDesignator.isEmpty() &&
-                          this->m_name.isEmpty() && !this->m_va && !this->m_real);
+        this->m_valid = m_id >= 0 || !this->m_countryIso.isEmpty() || !this->m_vDesignator.isEmpty() ||
+                        !this->m_name.isEmpty() || this->m_va || this->m_real;
     }
 
     CAirlineIcaoCodeList CAirlineIcaoFilter::filter(const CAirlineIcaoCodeList &inContainer) const

src/gui/models/listmodelbase.cpp

@@ -112,7 +112,7 @@ namespace swift::gui::models
     bool CListModelBase<T, UseCompare>::setData(const QModelIndex &index, const QVariant &value, int role)
     {
         auto dataRole = static_cast<Qt::ItemDataRole>(role);
-        if (!(dataRole == Qt::UserRole || dataRole == Qt::EditRole)) { return false; }
+        if (dataRole != Qt::UserRole && dataRole != Qt::EditRole) { return false; }
 
         // check / init
         if (!this->isValidIndex(index)) { return false; }