Run the compiler validation suite for Android #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aah, got much further with the clang package, that shaved 1 hour off the build. 🎆 Add the |
|
Can't read some of the failing logs, I think those runners ran out of disk space and it couldn't extract them. For the docker runs, you can probably delete all of |
Do you mean by applying https://patch-diff.githubusercontent.com/raw/swiftlang/swift/pull/81398.patch to I can try to coerce it manually, unless you know of an easier way? |
|
Remove the |
|
That reduced the number of failures for the 6.2 branch from 90 (https://github.com/swift-android-sdk/swift-docker/actions/runs/15475430398/job/43569489696): 90 failuresto 77 (https://github.com/swift-android-sdk/swift-docker/actions/runs/15495418271/job/43630847780): 77 failures |
|
There's only 2 failures on development (https://github.com/swift-android-sdk/swift-docker/actions/runs/15495418271/job/43630847776): 2 failures |
|
Looks like you'll need swiftlang/swift#81312 for 6.2 also, plus some additional tweaks for the last 2-3 failing tests, will look at those. |
|
OK, strangely you will need swiftlang/swift#81643 also for 6.2, those two pulls should get 6.2 passing the compiler validation suite. I will roll up all the 6.2 commits we need into an upstream pull and submit it later.
These are not reproducible on the community Android CI or 6.2, so they appear to be trunk regressions related to Docker? Reverting swiftlang/swift@a65912f09 in 6.3 alone should fix the first one, whereas I have no idea about that new trunk crasher test only failing in Docker: simply patch it with |
OK, but I won't be able to work on it until Tuesday at the earliest, so if you want to give it a shot before then, you can update the patch at https://github.com/swift-android-sdk/swift-android-sdk/blob/main/swift-android-devel-pr81398.patch 1 and re-run the swift-docker action (https://github.com/swift-android-sdk/swift-docker/actions/workflows/pull_request.yml) to see what happens. Footnotes
|
|
I'm unable to push to this repo: |
Sorry about that – I assumed since you were a member of the org, you would have write access. I've converted you to an owner, so you should be able to push to any of the repos now. |
|
I can restart the CI now, but still can't push: same error. |
That's weird. Maybe because it is a fork of https://github.com/swiftlang/swift-docker or something? Are you trying to push to PR #8 build-toolchain branch? Are you able to make a commit a change via the web editor, e.g. to https://github.com/swift-android-sdk/swift-docker/edit/build-toolchain/README.md ? |
|
Also, if you are logged in with a Personal Access Token, is it possible your token is constrained to certain repositories? |
|
Ah yes, I use the PAT to push to github, that may be blocking me from pushing to outside orgs, though it used to give me a different error for that. |
OK, that worked, so the PAT is the issue. I'll use the web editor for now, as I never found a solution to the PAT permissions before. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.