feat(es/minifier): Compress foo ? num : 0 into num * !!foo (#9908)

**Related issue:**
 - Closes #9898

Author: Austaras

crates/swc/tests/tsc-references/parserRealSource14.2.minified.js

@@ -167,7 +167,7 @@ import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
         }, ctx = new AstPathContext();
         return TypeScript.getAstWalkerFactory().walk(script, function(cur, parent, walker) {
             if (isValidAstNode(cur)) {
-                var inclusive = hasFlag(options, 1) || cur.nodeType === TypeScript.NodeType.Name || pos === script.limChar, minChar = cur.minChar, limChar = cur.limChar + (inclusive ? 1 : 0);
+                var inclusive = hasFlag(options, 1) || cur.nodeType === TypeScript.NodeType.Name || pos === script.limChar, minChar = cur.minChar, limChar = cur.limChar + +!!inclusive;
                 if (pos >= minChar && pos < limChar) {
                     var previous = ctx.path.ast();
                     (null == previous || cur.minChar >= previous.minChar && cur.limChar <= previous.limChar) && ctx.path.push(cur);

crates/swc/tests/vercel/full/d3-time-format/1/output/index.js

@@ -187,7 +187,7 @@ export default function v(e) {
             if (!e || "Z" in a || (a.Z = 0), "p" in a && (a.H = a.H % 12 + 12 * a.p), void 0 === a.m && (a.m = "q" in a ? a.q : 0), "V" in a) {
                 if (a.V < 1 || a.V > 53) return null;
                 "w" in a || (a.w = 1), "Z" in a ? (c = (o = (c = s(h(a.y, 0, 1))).getUTCDay()) > 4 || 0 === o ? f.ceil(c) : f(c), c = i.offset(c, (a.V - 1) * 7), a.y = c.getUTCFullYear(), a.m = c.getUTCMonth(), a.d = c.getUTCDate() + (a.w + 6) % 7) : (c = (o = (c = g(h(a.y, 0, 1))).getDay()) > 4 || 0 === o ? r.ceil(c) : r(c), c = t.offset(c, (a.V - 1) * 7), a.y = c.getFullYear(), a.m = c.getMonth(), a.d = c.getDate() + (a.w + 6) % 7);
-            } else ("W" in a || "U" in a) && ("w" in a || (a.w = "u" in a ? a.u % 7 : "W" in a ? 1 : 0), o = "Z" in a ? s(h(a.y, 0, 1)).getUTCDay() : g(h(a.y, 0, 1)).getDay(), a.m = 0, a.d = "W" in a ? (a.w + 6) % 7 + 7 * a.W - (o + 5) % 7 : a.w + 7 * a.U - (o + 6) % 7);
+            } else ("W" in a || "U" in a) && ("w" in a || (a.w = "u" in a ? a.u % 7 : +("W" in a)), o = "Z" in a ? s(h(a.y, 0, 1)).getUTCDay() : g(h(a.y, 0, 1)).getDay(), a.m = 0, a.d = "W" in a ? (a.w + 6) % 7 + 7 * a.W - (o + 5) % 7 : a.w + 7 * a.U - (o + 6) % 7);
             return "Z" in a ? (a.H += a.Z / 100 | 0, a.M += a.Z % 100, s(a)) : g(a);
         };
     }

crates/swc/tests/vercel/full/react-instantsearch/2/output/index.js

@@ -25,7 +25,7 @@ var f = function(e) {
     return e.props.indexId === t;
 }, h = function(e, t) {
     var r = p(e), a = p(t);
-    return r && !a ? -1 : !r && a ? 1 : 0;
+    return r && !a ? -1 : +(!r && !!a);
 };
 export default function S(u) {
     var o, l, S = u.indexName, v = u.initialState, x = u.searchClient, _ = u.resultsState, y = u.stalledSearchDelay, w = s(x, S, t({}, c));

crates/swc_ecma_minifier/src/compress/pure/conds.rs

@@ -15,10 +15,11 @@ impl Pure<'_> {
     /// - `!foo ? true : bar` => `!foo || bar`
     /// - `foo ? false : bar` => `!foo && bar`
     pub(super) fn compress_conds_as_logical(&mut self, e: &mut Expr) {
-        let cond = match e {
-            Expr::Cond(cond) => cond,
-            _ => return,
-        };
+        if !self.options.conditionals {
+            return;
+        }
+
+        let Expr::Cond(cond) = e else { return };
 
         let lt = cond.cons.get_type();
         if let Value::Known(Type::Bool) = lt {
@@ -100,10 +101,7 @@ impl Pure<'_> {
             return;
         }
 
-        let cond = match e {
-            Expr::Cond(v) => v,
-            _ => return,
-        };
+        let Expr::Cond(cond) = e else { return };
 
         match (&mut *cond.cons, &mut *cond.alt) {
             (Expr::Bin(cons @ BinExpr { op: op!("||"), .. }), alt)
@@ -132,6 +130,58 @@ impl Pure<'_> {
         }
     }
 
+    ///
+    /// - `foo ? num : 0` => `num * !!foo`
+    /// - `foo ? 0 : num` => `num * !foo`
+    pub(super) fn compress_conds_as_arithmetic(&mut self, e: &mut Expr) {
+        if !self.options.conditionals {
+            return;
+        }
+
+        let Expr::Cond(cond) = e else { return };
+        let span = cond.span;
+
+        match (&mut *cond.cons, &mut *cond.alt) {
+            (
+                Expr::Lit(Lit::Num(Number { value, .. })),
+                Expr::Lit(Lit::Num(Number { value: 0.0, .. })),
+            ) if *value > 0.0 => {
+                report_change!("conditionals: `foo ? num : 0` => `num * !!foo`");
+                self.changed = true;
+
+                let left = cond.cons.take();
+                let mut right = cond.test.take();
+                self.negate_twice(&mut right, false);
+
+                *e = Expr::Bin(BinExpr {
+                    span,
+                    op: op!("*"),
+                    left,
+                    right,
+                })
+            }
+            (
+                Expr::Lit(Lit::Num(Number { value: 0.0, .. })),
+                Expr::Lit(Lit::Num(Number { value, .. })),
+            ) if *value > 0.0 => {
+                report_change!("conditionals: `foo ? 0 : num` => `num * !foo`");
+                self.changed = true;
+
+                let left = cond.alt.take();
+                let mut right = cond.test.take();
+                self.negate(&mut right, false, false);
+
+                *e = Expr::Bin(BinExpr {
+                    span,
+                    op: op!("*"),
+                    left,
+                    right,
+                })
+            }
+            _ => (),
+        }
+    }
+
     pub(super) fn negate_cond_expr(&mut self, cond: &mut CondExpr) {
         if negate_cost(&self.expr_ctx, &cond.test, true, false) >= 0 {
             return;

crates/swc_ecma_minifier/src/compress/pure/mod.rs

@@ -476,6 +476,8 @@ impl VisitMut for Pure<'_> {
             debug_assert_valid(e);
         }
 
+        self.compress_conds_as_arithmetic(e);
+
         self.lift_seqs_of_bin(e);
 
         if e.is_seq() {

crates/swc_ecma_minifier/tests/benches-full/d3.js

@@ -3841,10 +3841,10 @@ function(global, factory) {
             ];
         }
         _edgecode(x, y) {
-            return (x === this.xmin ? 0b0001 : x === this.xmax ? 0b0010 : 0b0000) | (y === this.ymin ? 0b0100 : y === this.ymax ? 0b1000 : 0b0000);
+            return (x === this.xmin ? 0b0001 : 0b0010 * (x === this.xmax)) | (y === this.ymin ? 0b0100 : 0b1000 * (y === this.ymax));
         }
         _regioncode(x, y) {
-            return (x < this.xmin ? 0b0001 : x > this.xmax ? 0b0010 : 0b0000) | (y < this.ymin ? 0b0100 : y > this.ymax ? 0b1000 : 0b0000);
+            return (x < this.xmin ? 0b0001 : 0b0010 * (x > this.xmax)) | (y < this.ymin ? 0b0100 : 0b1000 * (y > this.ymax));
         }
     }
     const tau$3 = 2 * Math.PI, pow = Math.pow;
@@ -5192,7 +5192,7 @@ function(global, factory) {
             else stream.point(to[0], to[1]);
         }
         function corner(p, direction) {
-            return 1e-6 > abs$2(p[0] - x0) ? direction > 0 ? 0 : 3 : 1e-6 > abs$2(p[0] - x1) ? direction > 0 ? 2 : 1 : 1e-6 > abs$2(p[1] - y0) ? direction > 0 ? 1 : 0 : direction > 0 ? 3 : 2; // abs(p[1] - y1) < epsilon
+            return 1e-6 > abs$2(p[0] - x0) ? 3 * !(direction > 0) : 1e-6 > abs$2(p[0] - x1) ? direction > 0 ? 2 : 1 : 1e-6 > abs$2(p[1] - y0) ? +(direction > 0) : direction > 0 ? 3 : 2; // abs(p[1] - y1) < epsilon
         }
         function compareIntersection(a, b) {
             return comparePoint(a.x, b.x);
@@ -7459,7 +7459,7 @@ function(global, factory) {
                 if (!Z || "Z" in d || (d.Z = 0), "p" in d && (d.H = d.H % 12 + 12 * d.p), void 0 === d.m && (d.m = "q" in d ? d.q : 0), "V" in d) {
                     if (d.V < 1 || d.V > 53) return null;
                     "w" in d || (d.w = 1), "Z" in d ? (week = (day$1 = (week = utcDate(newDate(d.y, 0, 1))).getUTCDay()) > 4 || 0 === day$1 ? utcMonday.ceil(week) : utcMonday(week), week = utcDay.offset(week, (d.V - 1) * 7), d.y = week.getUTCFullYear(), d.m = week.getUTCMonth(), d.d = week.getUTCDate() + (d.w + 6) % 7) : (week = (day$1 = (week = localDate(newDate(d.y, 0, 1))).getDay()) > 4 || 0 === day$1 ? monday.ceil(week) : monday(week), week = day.offset(week, (d.V - 1) * 7), d.y = week.getFullYear(), d.m = week.getMonth(), d.d = week.getDate() + (d.w + 6) % 7);
-                } else ("W" in d || "U" in d) && ("w" in d || (d.w = "u" in d ? d.u % 7 : "W" in d ? 1 : 0), day$1 = "Z" in d ? utcDate(newDate(d.y, 0, 1)).getUTCDay() : localDate(newDate(d.y, 0, 1)).getDay(), d.m = 0, d.d = "W" in d ? (d.w + 6) % 7 + 7 * d.W - (day$1 + 5) % 7 : d.w + 7 * d.U - (day$1 + 6) % 7);
+                } else ("W" in d || "U" in d) && ("w" in d || (d.w = "u" in d ? d.u % 7 : +("W" in d)), day$1 = "Z" in d ? utcDate(newDate(d.y, 0, 1)).getUTCDay() : localDate(newDate(d.y, 0, 1)).getDay(), d.m = 0, d.d = "W" in d ? (d.w + 6) % 7 + 7 * d.W - (day$1 + 5) % 7 : d.w + 7 * d.U - (day$1 + 6) % 7);
                 return(// If a time zone is specified, all fields are interpreted as UTC and then
                 // offset according to the specified time zone.
                 "Z" in d ? (d.H += d.Z / 100 | 0, d.M += d.Z % 100, utcDate(d)) : localDate(d));