fix(es/renamer): Check preserved in normal renaming mode (#9666)

**Description:**

Check `preserved` in normal renaming mode

**Related issue:**

 - Closes #9663

Author: unbyte

.changeset/sixty-ladybugs-help.md

@@ -0,0 +1,6 @@
+---
+swc_core: patch
+swc_ecma_transforms_base: patch
+---
+
+fix(es/renamer): check `preserved` in normal renaming mode

crates/swc/tests/projects.rs

@@ -601,6 +601,15 @@ fn issue_1203() {
     assert!(!f.contains("return //"))
 }
 
+#[test]
+fn issue_9663() {
+    let f = file("tests/projects/issue-9663/input.js").unwrap();
+    println!("{}", f);
+
+    assert!(f.contains("set = Reflect.set"));
+    assert!(!f.contains("function set1("));
+}
+
 #[test]
 fn codegen_1() {
     let f = file("tests/projects/codegen-1/input.js").unwrap();

crates/swc/tests/projects/issue-9663/.swcrc

@@ -0,0 +1,9 @@
+{
+    "jsc": {
+        "parser": {
+            "syntax": "ecmascript"
+        },
+        "externalHelpers": false,
+        "target": "es5"
+    }
+}

crates/swc/tests/projects/issue-9663/input.js

@@ -0,0 +1,15 @@
+class A {
+    world = false
+}
+
+eval("hello")
+
+class B extends A {
+    set hello(v) {
+        super.world = v
+    }
+
+    get hello() {
+        return super.world
+    }
+}

crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs

@@ -99,6 +99,7 @@ impl Scope {
         to: &mut RenameMap,
         previous: &RenameMap,
         reverse: &mut ReverseMap,
+        preserved: &FxHashSet<Id>,
         preserved_symbols: &FxHashSet<Atom>,
     ) where
         R: Renamer,
@@ -113,6 +114,7 @@ impl Scope {
             previous,
             reverse,
             queue,
+            preserved,
             preserved_symbols,
         );
 
@@ -122,6 +124,7 @@ impl Scope {
                 to,
                 &Default::default(),
                 reverse,
+                preserved,
                 preserved_symbols,
             );
         }
@@ -134,14 +137,19 @@ impl Scope {
         previous: &RenameMap,
         reverse: &mut ReverseMap,
         queue: Vec<Id>,
+        preserved: &FxHashSet<Id>,
         preserved_symbols: &FxHashSet<Atom>,
     ) where
         R: Renamer,
     {
         let mut n = 0;
 
         for id in queue {
-            if to.get(&id).is_some() || previous.get(&id).is_some() || id.0 == "eval" {
+            if preserved.contains(&id)
+                || to.get(&id).is_some()
+                || previous.get(&id).is_some()
+                || id.0 == "eval"
+            {
                 continue;
             }
 

crates/swc_ecma_transforms_base/src/rename/mod.rs

@@ -191,6 +191,7 @@ where
                 &mut map,
                 &self.previous_cache,
                 &mut Default::default(),
+                &self.preserved,
                 &unresolved,
             );
         }