Skip to content

Make InvalidRef a critical exception to avoid suppression #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2021

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Jun 17, 2021

Fixes swaggest/php-swagger2-schema#8 one more time.

@github-actions
Copy link

github-actions bot commented Jun 17, 2021

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Makefile 1 32 23 0 9 7 2K (+3B)
Markdown 2 594 (+6) 466 (+4) 0 128 (+2) 0 19.1K (+190B)
PHP 133 11066 (+59) 8009 (+53) 1468 1589 (+6) 553 (-1) 319.6K (-1.3K)
YAML 4 (+2) 147 (+85) 132 (+79) 1 14 (+6) 0 3.6K (+2.3K)

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #122 (3d82e48) into master (07e8698) will increase coverage by 2.32%.
The diff coverage is 95.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     90.01%   92.34%   +2.32%     
- Complexity        0      756     +756     
============================================
  Files            27       27              
  Lines          1603     1645      +42     
============================================
+ Hits           1443     1519      +76     
+ Misses          160      126      -34     
Impacted Files Coverage Δ
src/RefResolver.php 96.58% <75.00%> (+0.92%) ⬆️
src/Structure/ClassStructureTrait.php 95.71% <92.30%> (-0.84%) ⬇️
src/Schema.php 95.92% <97.43%> (+1.21%) ⬆️
src/Constraint/Content.php 93.33% <100.00%> (ø)
src/Constraint/Format.php 96.96% <100.00%> (+0.19%) ⬆️
src/Constraint/Type.php 93.65% <100.00%> (+42.85%) ⬆️
src/JsonSchema.php 100.00% <100.00%> (ø)
src/MagicMapTrait.php 83.78% <100.00%> (+5.40%) ⬆️
src/Wrapper.php 59.01% <100.00%> (+1.38%) ⬆️
src/Structure/ObjectItemTrait.php 73.84% <0.00%> (-2.35%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec90855...3d82e48. Read the comment docs.

@vearutop vearutop merged commit d0126bd into master Jun 17, 2021
@vearutop vearutop deleted the fail-unresolved-ref-pt2 branch June 17, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should this check for missing definitions?
1 participant