Fix and improve rearrange #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines Of Code
|
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 96.79% 96.63% -0.16%
==========================================
Files 10 10
Lines 530 535 +5
==========================================
+ Hits 513 517 +4
- Misses 17 18 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43.
Fixes #38.
This PR removes unnecessary keys stripping as suggested in #43 (comment).
Also it adds rearrangement criteria for non-scalar properties (only objects) using XOR hash.
Also it fixes XOR hash collision when having pairs of properties with similarities in name, e.g. hash of
{"aX":1,"bX":1}was equal to hash of{"aY":1,"bY":1}.