Skip to content

Rearrange equal items for non-homogeneous arrays, fixes #33 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

vearutop
Copy link
Member

This PR extends array rearrangement heuristics to detect items that are recursively equal and keep their original placement when calculating diff.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #35 into master will increase coverage by 0.78%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   95.95%   96.74%   +0.78%     
==========================================
  Files           9       10       +1     
  Lines         470      522      +52     
==========================================
+ Hits          451      505      +54     
+ Misses         19       17       -2     
Impacted Files Coverage Δ
src/JsonHash.php 94.59% <94.59%> (ø)
src/JsonDiff.php 96.46% <100.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1ce3a...fa5b459. Read the comment docs.

@vearutop vearutop merged commit fbad15d into master Sep 24, 2020
@vearutop vearutop deleted the rearrange-equal branch September 24, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant