Skip to content

ref #3958, support utf16 fragments on the deeplink plugin #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheNorthMemory
Copy link
Contributor

Description

  1. let deep-link plugin to support the UTF-16 fragments

Motivation and Context

How Has This Been Tested?

npm run e2e-cypress

  Deep linking feature
    in Swagger 2
      UTF16 fragments with `docExpansion: none` enabled
        ✓ should expand the tag(шеллы) (1164ms)
        ✓ should expand the operation(пошел) (1257ms)
    in OpenAPI 3
      UTF16 fragments with `docExpansion: none` enabled
        ✓ should expand the tag(шеллы) (1265ms)
        ✓ should expand the operation(пошел) (1143ms)

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

TheNorthMemory added a commit to TheNorthMemory/wechat-swagger that referenced this pull request Oct 5, 2018
@shockey shockey force-pushed the bug/3958-support-utf16-fragments-on-deeplink-plugin branch from 8e9cec0 to f1de68b Compare October 18, 2018 21:40
@shockey shockey force-pushed the bug/3958-support-utf16-fragments-on-deeplink-plugin branch from a5a37a8 to e9cb242 Compare October 18, 2018 21:52
@shockey shockey merged commit 1791759 into swagger-api:master Oct 18, 2018
@shockey
Copy link
Contributor

shockey commented Oct 18, 2018

thanks @TheNorthMemory!

@TheNorthMemory TheNorthMemory deleted the bug/3958-support-utf16-fragments-on-deeplink-plugin branch October 19, 2018 01:18
@TheNorthMemory
Copy link
Contributor Author

u r welcome :)

TheNorthMemory added a commit to TheNorthMemory/wechat-swagger that referenced this pull request Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants