[Swift4] Add throw to reserved words #6952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't at the moment but of course we welcome more tests to cover different edge cases. |
wing328
changed the title
wing328
reviewed
Nov 15, 2017
| unset |
There was a problem hiding this comment.
I wonder why this is unset...
|
@atanasbozhkov if you've time, I wonder if you can do the same to Swift3Codegen.java. |
|
@wing328 - yes I actually thought about that today. I'll look at the integration tests as well - any suggestions where they should go? |
wing328
added a commit
that referenced
this pull request
Nov 16, 2017
* Revert "[csharp] clean boolean additional properties 6784 (#6899)" This reverts commit 2c9f98c. * Revert "[Swift4] Add throw to reserved words (#6952)" This reverts commit 970de01. * Revert "add a docker build tag for pushing docker image instead of just latest (#6837)" This reverts commit 4e482ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Adding
throwin the list of Swift 4 reserved words. This is to address #6919(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
I have simply added the word to the hash-set and regenerated the Petstore samples.
I haven't added any changes to the Swift4 tests - currently they seem to only test a single word as a pass condition. Should there be some integration tests that iterate through the set values to see if all reserved words are escaped properly?
Lastly - it's my first time contributing to the project - please let me know if I've skipped a step in the PR process - I'll do my best to fix it.