#4788: remove System.getProperty() from java-inflector + undertow codegens #5066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
changed the title
ePaul
changed the title
…ens. It was just used for apiPackage/modelPackage, for which we have regular parameters.
ePaul
force-pushed
the
4788-remove-getProperty-from-languages
branch
from
7b41ae4 to
78dafec
Compare
|
This needs some reconsideration, I'll reopen it later again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove System.getProperty from language codegens.
It was just used for apiPackage/modelPackage, for which we have regular parameters.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/java-undertow-server.sh, bin/java-inflector-petstore-server.sh (before the change, afterwards nothing changed.)
2.3.0branch for breaking (non-backward compatible) changes. (unclear, see below)Description of the PR
This removes the usage of system properties from UndertowCodegen and JavaInflectorCodegen. It adds a warning in case the properties are still used. (This is part of a bigger effort to get rid of system properties, who have bad effects if there are have multiple (consecutive or even parallel) Codegen runs in the same JVM – see #4788.)
I'm not sure if this counts as a breaking change – the original effect of the system property being set is not there anymore. – If so, I can put this against the 2.3.0 branch, and create a similar change for master which just outputs the warning, but still uses the system property. Opinions?
Also, is WARN the right level, or should this be ERROR?