Skip to content

Commit 0da9932

Browse files
committed
Code cleanup
* remove @SuppressWarnings("hiding") * organize imports * use constants
1 parent db4b492 commit 0da9932

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

src/main/java/io/swagger/codegen/languages/DefaultCodegenConfig.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,8 @@ public void processOpts() {
160160
this.setTemplateDir((String) additionalProperties.get(CodegenConstants.TEMPLATE_DIR));
161161
}
162162

163-
//todo: replace hardcore string for constant on "CodegenConstans" class once publishing issue on codegen be resolved. (02-15-18)
164-
if (additionalProperties.containsKey(/**fixme: CodegenConstants.TEMPLATE_VERSION*/ "templateVersion")) {
165-
this.setTemplateVersion((String) additionalProperties.get(/**fixme: CodegenConstants.TEMPLATE_VERSION*/ "templateVersion"));
163+
if (additionalProperties.containsKey(CodegenConstants.TEMPLATE_VERSION)) {
164+
this.setTemplateVersion((String) additionalProperties.get(CodegenConstants.TEMPLATE_VERSION));
166165
}
167166

168167
if (additionalProperties.containsKey(CodegenConstants.MODEL_PACKAGE)) {

src/main/java/io/swagger/codegen/languages/java/JavaClientCodegen.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
import static io.swagger.codegen.languages.helpers.ExtensionHelper.getBooleanValue;
55
import static java.util.Collections.sort;
66

7-
import com.fasterxml.jackson.databind.JsonNode;
87
import io.swagger.codegen.CliOption;
9-
import io.swagger.codegen.CodegenArgument;
108
import io.swagger.codegen.CodegenConstants;
119
import io.swagger.codegen.CodegenModel;
1210
import io.swagger.codegen.CodegenOperation;
@@ -18,23 +16,25 @@
1816
import io.swagger.codegen.languages.features.GzipFeatures;
1917
import io.swagger.codegen.languages.features.PerformBeanValidationFeatures;
2018

21-
import io.swagger.v3.core.util.Yaml;
22-
import org.apache.commons.io.IOUtils;
2319
import org.apache.commons.lang3.BooleanUtils;
2420
import org.apache.commons.lang3.StringUtils;
2521
import org.slf4j.Logger;
2622
import org.slf4j.LoggerFactory;
2723

2824
import java.io.File;
29-
import java.io.IOException;
30-
import java.io.InputStream;
31-
import java.util.*;
25+
import java.util.ArrayList;
26+
import java.util.Comparator;
27+
import java.util.HashMap;
28+
import java.util.Iterator;
29+
import java.util.LinkedHashMap;
30+
import java.util.LinkedList;
31+
import java.util.List;
32+
import java.util.Map;
3233
import java.util.regex.Pattern;
3334

3435
public class JavaClientCodegen extends AbstractJavaCodegen implements BeanValidationFeatures, PerformBeanValidationFeatures, GzipFeatures {
3536
static final String MEDIA_TYPE = "mediaType";
3637

37-
@SuppressWarnings("hiding")
3838
private static final Logger LOGGER = LoggerFactory.getLogger(JavaClientCodegen.class);
3939

4040
public static final String USE_RX_JAVA = "useRxJava";

0 commit comments

Comments
 (0)