Commit 826bfa6
committed
polish bridge config (#925)
Alright y'all. After a bunch of conversations about the overall config
and mental model to apply to the project (from the user perspective),
this PR ended up _huge_. It'll be a tough review. I'm sorry 😭
This is a pretty large shift.
Here's a breakdown of the broad strokes:
- The `Plugin` trait was removed from `-types`.
- New traits added: `SenderInput` and `ReceiverOutput` to represent the
non-svix portions of the dataflow.
- Removed the `-plugin-webhook-receiver` plugin crate.
- moved the http server from the `-plugin-webhook-receiver` crate into
`svix-bridge`.
- "queue forwarders" into the `-plugin-queue-consumer` crate.
- Renamed the `-plugin-queue-consumer` crate to just `-plugin-queue` (it
now provides both `SenderInput` and `ReceiverOutput` implementation for
the various queue backends.
- all crates etc have been renamed: `s/svix-webhook-bridge/svix-bridge/`
What else, what else, what else...
The example config has been split into 2: one showing `senders` and
another for `receivers`.
The readme has been gutted (but probably needs to be fleshed out a bit
more... again). It felt silly to effectively duplicate the example
configs in code fence blocks a 2nd time.
To sweeten the deal, new test coverage has been added for select
portions of the config parsing as well as for the HTTP receiver stuff.
Both the sender and receiver example configs are now checked in the test
suite to make sure they at least parse without failure. These tests
should be expanded to inspect the actual data, but this diff is so
big... 😭
We didn't have any tests for the HTTP handler execution before this, so
that's very nice to have.1 parent 7a3b53b commit 826bfa6
File tree
53 files changed
+1962
-1523
lines changed- .github/workflows
- bridge
- generic-queue
- src
- svix-bridge-plugin-queue
- src
- gcp_pubsub
- rabbitmq
- receiver_output
- redis
- sqs
- tests
- svix-bridge-types
- src
- svix-bridge
- src
- config
- runtime
- webhook_receiver
- webhook-bridge
- svix-webhook-bridge-plugin-queue-consumer/src
- svix-webhook-bridge-plugin-webhook-receiver
- src
- svix-webhook-bridge
- src/config
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
53 files changed
+1962
-1523
lines changedLines changed: 12 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
File renamed without changes.
File renamed without changes.
File renamed without changes.
0 commit comments