oncreate async, fixes #904 #907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just checking if the function is async and outputting
async function
if so, rather than just always only outputtingfunction
. The tests don't do anything but useawait
inside the function. If theasync
keyword is not present, usingawait
in the function is a syntax error, so runtime tests will fail.I also wrote tests for
js/samples
, but as the README says to avoid those and the runtime tests are sufficient, I am not including them unless you'd like me to.