-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
mark module variable #4469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conduitry
merged 6 commits into
sveltejs:master
from
tanhauhau:tanhauhau/context-module-mark-variable
Feb 29, 2020
Merged
mark module variable #4469
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9777fcd
mark module variable
tanhauhau b9a84a5
check if module_scope is defined
tanhauhau d432a42
group condition for code review
tanhauhau 2549e9f
tidy
Conduitry 5e0ea94
Merge branch 'master' into pr/4469
Conduitry a841a8a
update changelog
Conduitry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
export default { | ||
test(assert, vars) { | ||
assert.deepEqual(vars, [ | ||
{ | ||
name: "a", | ||
export_name: null, | ||
injected: false, | ||
module: true, | ||
mutated: false, | ||
reassigned: true, | ||
referenced: false, | ||
referenced_from_script: false, | ||
writable: true | ||
}, | ||
{ | ||
name: "b", | ||
export_name: null, | ||
injected: false, | ||
module: true, | ||
mutated: true, | ||
reassigned: false, | ||
referenced: false, | ||
referenced_from_script: false, | ||
writable: true | ||
}, | ||
{ | ||
name: "c", | ||
export_name: null, | ||
injected: false, | ||
module: true, | ||
mutated: false, | ||
reassigned: false, | ||
referenced: false, | ||
referenced_from_script: false, | ||
writable: true | ||
}, | ||
{ | ||
name: "d", | ||
export_name: null, | ||
injected: false, | ||
module: true, | ||
mutated: false, | ||
reassigned: false, | ||
referenced: false, | ||
referenced_from_script: false, | ||
writable: true | ||
}, | ||
{ | ||
name: "c", | ||
export_name: null, | ||
injected: false, | ||
module: false, | ||
mutated: false, | ||
reassigned: true, | ||
referenced: false, | ||
referenced_from_script: true, | ||
writable: true | ||
}, | ||
{ | ||
name: "foo", | ||
export_name: null, | ||
injected: false, | ||
module: false, | ||
mutated: false, | ||
reassigned: false, | ||
referenced: false, | ||
referenced_from_script: false, | ||
writable: false | ||
} | ||
]); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<script context='module'> | ||
let a = {}; | ||
let b = {}; | ||
let c = {}; | ||
let d = {}; | ||
</script> | ||
<script> | ||
let c = {}; | ||
|
||
a = 1; | ||
b.x = 1; | ||
|
||
function foo() { | ||
let d = {}; | ||
c = 1; | ||
d.x = 1; | ||
} | ||
</script> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.