Skip to content

support once modifier on component events, fail on others #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2019
Merged

support once modifier on component events, fail on others #2987

merged 2 commits into from
Jun 9, 2019

Conversation

Rich-Harris
Copy link
Member

fixes #2654 and fixes #2977

@Conduitry
Copy link
Member

I'm not sure what's up with this type checking test failure. I had another recent PR where this failed, and I had to run npm run typecheck locally to see it myself, but it didn't appear during npm run build nor did I get red squigglies in VS Code.

@Rich-Harris
Copy link
Member Author

I get an error after doing npm install. just pushed a fix, hopefully

@Conduitry
Copy link
Member

Oh it's because of b6b7c62. npm run tsd should get moved from prepare to build I think - for other reasons as well, not just to make the build fail early.

@Rich-Harris Rich-Harris merged commit 1102ff6 into master Jun 9, 2019
@Rich-Harris Rich-Harris deleted the gh-2654 branch June 9, 2019 21:34
@Rich-Harris
Copy link
Member Author

makes sense. done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event modifiers not affecting dispatched events Feature Request: allow once modifier on custom event handlers
2 participants
@Rich-Harris @Conduitry