Implement local transitions #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 48 48
======================================
Hits 48 48Continue to review full report at Codecov.
|
This was referenced Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was dreading this task but it turned out to be fairly simple. With this change, we call
.i()and.o()methods on fragments with a1argument if the change is local (i.e. the call is in apakaupdatemethod). Then, local transitions are wrapped in anif (local) ...block.Local transitions present an opportunity to generate more optimal code — in a situation like this...
{#if x} {#if y} <div in:foo|local>...</div> {/if} {/if}...the outer block doesn't need any transition code at all.
Am in two minds about whether to try and implement that now or worry about it later.This PR is dedicated to @jacwright 😀