Skip to content

fix: avoid unnecessary read version increments #15777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

dummdidumm
Copy link
Member

Fixes #15262

Apologies @trueadm , you were right in #15694 that the check was not redundant, my suggestion was wrong. reaction cannot be null, so when previous_reaction is null the check was now true when it should've been false. Therefore reinstating this check.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15777

@Rich-Harris Rich-Harris merged commit ea4843c into main Apr 16, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the reinstate-null-check branch April 16, 2025 19:24
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hydration takes way too long
2 participants