Skip to content

fix: do not treat reassigned synthetic binds as state in runes mode #14236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Nov 9, 2024

Closes #14233

The fix was slightly more involved because at that state we still can't have full certainty if we are in rune mode because we are still modifying the module scope.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 9, 2024

🦋 Changeset detected

Latest commit: c2a830e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 9, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14236

declaration.kind === 'normal' &&
declaration.declaration_kind === 'let' &&
declaration.reassigned &&
!runes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of passing runes and using it here, could we do if(!runes) { for... check() below instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it, thanks!

@paoloricciuti paoloricciuti merged commit 7bc94b9 into main Nov 10, 2024
11 checks passed
@paoloricciuti paoloricciuti deleted the reassigned-store-not-state branch November 10, 2024 19:55
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5.1.13: Reassigning store leads to undefined
2 participants