Skip to content

fix: ensure onMount correctly fires when new expressions are used #14049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 30, 2024

Fixes #14042. We need to support new expressions too.

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: e83d037

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 30, 2024

pnpm add https://pkg.pr.new/svelte@14049

commit: e83d037

@trueadm trueadm marked this pull request as draft October 30, 2024 20:55
@trueadm trueadm changed the title fix: ensure onMount correctly fires when used externally fix: ensure onMount correctly fires when new expressions are used Oct 30, 2024
@trueadm trueadm marked this pull request as ready for review October 30, 2024 20:58
@trueadm trueadm merged commit 4a5a0b1 into main Oct 30, 2024
10 checks passed
@trueadm trueadm deleted the onmount-fix branch October 30, 2024 21:08
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onMount ignored in class constructors
2 participants